Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigMerge should make sure the base and new configuration file paths are different #4134

Open
vladak opened this issue Dec 14, 2022 · 1 comment
Open

ConfigMerge should make sure the base and new configuration file paths are different #4134

vladak opened this issue Dec 14, 2022 · 1 comment
Assignees
@vladak
Labels
bug tools Python tools

Comments

@vladak
Copy link
Member

vladak commented Dec 14, 2022

The ConfigMerge tool should make sure that (canonicalized) paths for the base and new files are different to avoid nasty surprises.

Inspired by #4133 (reply in thread)_
@vladak vladak added the bug label Dec 14, 2022
@vladak vladak self-assigned this Dec 14, 2022
@vladak
Copy link
Member Author

vladak commented Dec 14, 2022

Also, the Docker scripts should check the return value of merge_config_files() and react accordingly, i.e. report the error and continue:

opengrok/docker/start.py

Lines 519 to 520 in c53c7ab

merge_config_files(read_only_config_file, OPENGROK_CONFIG_FILE,
tmp_out, jar=OPENGROK_JAR, loglevel=log_level)

@vladak vladak added the tools Python tools label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladak vladak

Labels
bug tools Python tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vladak