deduplication of date formats in repositories #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicts resolved |
tulinkry
commented
Jan 20, 2017
| { | ||
| // initialize date formatters | ||
| for (int i = 0; i < datePatterns.length; i++) { | ||
| formatters[i] = new SimpleDateFormat(datePatterns[i], Locale.US); |
There was a problem hiding this comment.
I'm not quite sure here about the locale. Maybe the default would be better choice.
There was a problem hiding this comment.
+1 it should match the locale the system is running with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1326
Reindex needed (not full, just some of the properities in configuration.xml have changed).