Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquiring next byte store may not change the state when shifting backwards #452

Closed
glukos opened this issue Sep 29, 2022 · 2 comments · Fixed by #453
Closed

Acquiring next byte store may not change the state when shifting backwards #452

glukos opened this issue Sep 29, 2022 · 2 comments · Fixed by #453
Assignees
@glukos

Comments

@glukos
Copy link
Contributor

glukos commented Sep 29, 2022 •
edited 

        if (adding > 0 && !bytesStore.inside(offset, checkSize0(adding - 1))) {
            acquireNextByteStore0(offset + adding - 1, false);

The logic above fails when bytesStore.start() is greater than offset, but the difference between start and offset is less than adding.
Real-life example is overwriting the header after we wrote a message.
@glukos glukos self-assigned this Sep 29, 2022
glukos added a commit that referenced this issue Sep 29, 2022
@glukos
Fix acquireNextByteStore0 when shifting backwards, closes #452
81f1efb
@glukos glukos linked a pull request Sep 29, 2022 that will close this issue
Fix acquireNextByteStore0 when shifting backwards #453
Merged
glukos added a commit that referenced this issue Sep 30, 2022
@glukos
Fix acquireNextByteStore0 when shifting backwards, closes #452
0fddc73
glukos added a commit that referenced this issue Sep 30, 2022
@glukos
Fix acquireNextByteStore0 when shifting backwards, closes #452
fe56a03
glukos added a commit that referenced this issue Sep 30, 2022
@glukos
Fix acquireNextByteStore0 when shifting backwards, closes #452
6ffb9ed
glukos added a commit that referenced this issue Sep 30, 2022
@glukos
Fixed acquireNextByteStore0 when shifting backwards, closes #452
c3fed70 
(cherry picked from commit 65f9a5c)
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Bytes-2.23.32, BOM-2.23.127

JerryShea pushed a commit that referenced this issue Oct 7, 2022
@glukos @JerryShea
Fixed acquireNextByteStore0 when shifting backwards, closes #452
49a8b78
JerryShea pushed a commit that referenced this issue Oct 7, 2022
@glukos @JerryShea
Fixed acquireNextByteStore0 when shifting backwards, closes #452
ac79b7c
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Bytes-2.22.28, BOM-2.22.162

@alamar alamar mentioned this issue Oct 18, 2022
Closed
@nicktindall nicktindall mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glukos glukos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix acquireNextByteStore0 when shifting backwards OpenHFT/Chronicle-Bytes
2 participants
@glukos @hft-team-city