Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jetbrains annotations dependencies as provided? #289

Closed
ahornace opened this issue Jun 8, 2021 · 3 comments
Closed

Make jetbrains annotations dependencies as provided? #289

ahornace opened this issue Jun 8, 2021 · 3 comments

Comments

@ahornace
Copy link

ahornace commented Jun 8, 2021

Hello,

we are using your library but unfortunately it brings jetbrains annotations with versions 12 and 19 as its dependencies whereas we use the newest version 21. We chose to exclude the annotations library in maven when adding chronicle-map, however, the Tomcat jar scanning still complains.

Do you think it would make sense to mark the library as provided (compile only)? The annotations themselves should not be required as a regular dependency since they mostly should be used by IDE and their RetentionPolicy is CLASS so they shouldn't be used by reflection. Furthermore, even official github page marks them as provided: https://github.com/JetBrains/java-annotations

Thanks!

@minborg
Copy link
Contributor

minborg commented Jun 9, 2021

As a side note, we are planning to upgrade to 21.

@minborg
Copy link
Contributor

minborg commented Jun 9, 2021

This is how it would look like in the TPB:

<dependency>
  <groupId>org.jetbrains</groupId>
  <artifactId>annotations</artifactId>
  <version>21.0.1</version>
  <scope>provided</scope>
</dependency>

@minborg
Copy link
Contributor

minborg commented Jun 11, 2021

Related to OpenHFT/OpenHFT#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants