This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Throw ClosedChannelException when FastJ8SocketChannel.read() fails due to underlying channel being closed #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
commented
Oct 11, 2022
src/main/java/net/openhft/chronicle/network/tcp/FastJ8SocketChannel.java
Outdated
Show resolved
Hide resolved
nicktindall
force-pushed
the
throw_correct_exception_when_channel_closed
branch
from
9c2aaa7
to
321713f
Compare
…e to underlying being closed. Fixes #214
nicktindall
force-pushed
the
throw_correct_exception_when_channel_closed
branch
from
321713f
to
89bb981
Compare
nicktindall
commented
Oct 27, 2022
| @@ -47,7 +47,7 @@ public int read(ByteBuffer buf) throws IOException { | |||
| if (buf == null) | |||
| throw new NullPointerException(); | |||
|
|
|||
| if (isBlocking() || isClosed() || !IOTools.isDirectBuffer(buf)) | |||
| if (isBlocking() || isClosed() || !IOTools.isDirectBuffer(buf) || !super.isOpen()) | |||
There was a problem hiding this comment.
Just means we don't attempt the "fast read" if we know the channel isn't open. The slow read behaves as you'd expect (throwing the ClosedChannelException when the channel is closed).
There was a problem hiding this comment.
The fast read throws an IOException from some com.sun package about an invalid file handle under those circumstances
There was a problem hiding this comment.
Probably still a chance we throw the IOException if the disconnect happens between the check and the read (though not sure if that can even happen), but it's substantially reduced.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
The ClosedChannelException is handled specially in e.g. TcpEventHandler, whereas the generic IOException ends up being logged.
We could perhaps also fix this by checking before we attempt to read from the channel, but that would leave room for a race condition, and potentially re-introduce some of the slowness this class attempts to avoid.
This approach just changes the exception after the error has occurred.