Better naming

OpenHFT · Jan 22, 2018 · 21fdc4f · 21fdc4f
1 parent 94807de
commit 21fdc4f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/net/openhft/chronicle/queue/impl/single/QueueInspector.java b/src/main/java/net/openhft/chronicle/queue/impl/single/QueueInspector.java
@@ -4,7 +4,7 @@
 import net.openhft.chronicle.wire.Wires;
 
 public final class QueueInspector {
-    private static final int LATEST_DOCUMENT_COMPLETE = Integer.MIN_VALUE;
+    private static final int NO_CURRENT_WRITER = Integer.MIN_VALUE;
 
     private final SingleChronicleQueue queue;
 
@@ -25,12 +25,11 @@ public int getWritingProcessId() {
                     return Wires.extractPidFromHeader(unfinishedHeader);
                 }
             }
-
         }
-        return LATEST_DOCUMENT_COMPLETE;
+        return NO_CURRENT_WRITER;
     }
 
     public static boolean isValidProcessId(final int writingProcessId) {
-        return writingProcessId != LATEST_DOCUMENT_COMPLETE;
+        return writingProcessId != NO_CURRENT_WRITER;
     }
 }
diff --git a/src/test/java/net/openhft/chronicle/queue/impl/single/QueueInspectorTest.java b/src/test/java/net/openhft/chronicle/queue/impl/single/QueueInspectorTest.java
@@ -46,7 +46,9 @@ public void shouldDetermineWritingProcessIdWhenDocumentIsNotComplete() throws IO
             appender.writeDocument(37L, ValueOut::int64);
             try (final DocumentContext ctx = appender.writingDocument()) {
                 ctx.wire().write("foo").int32(17L);
-                assertThat(inspector.getWritingProcessId(), is(OS.getProcessId()));
+                final int writingProcessId = inspector.getWritingProcessId();
+                assertThat(writingProcessId, is(OS.getProcessId()));
+                assertThat(QueueInspector.isValidProcessId(writingProcessId), is(true));
             }
         }
     }