Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put esoteric/test/legacy roll cycles a little more out-of-reach #1221

Closed
nicktindall opened this issue Oct 13, 2022 · 1 comment
Closed

Put esoteric/test/legacy roll cycles a little more out-of-reach #1221

nicktindall opened this issue Oct 13, 2022 · 1 comment

Comments

@nicktindall
Copy link
Contributor

The RollCycles enum contains definitions for a bunch of common roll cycles. It also includes some definitions for legacy roll cycles, test roll cycles and some specialised roll cycles for unusual configurations.

Currently if you're looking at the decompiled RollCycles class there's no indication of which ones you should probably use (it's explained in JavaDoc) and getting it wrong can have some unexpected results.

The plan is to leave the "common"/"sensible" set of roll cycles in the RollCycles enum and move the more specialised ones out to separate enums to make it clear that choosing them means you're going somewhat "off piste".

nicktindall added a commit to OpenHFT/OpenHFT that referenced this issue Oct 27, 2022
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Queue-5.24ea1, BOM-2.24ea6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants