Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused throwExceptionIfClosed calls #1386

Closed
tgd opened this issue Jul 12, 2023 · 1 comment
Closed

Remove unused throwExceptionIfClosed calls #1386

tgd opened this issue Jul 12, 2023 · 1 comment
Assignees
@tgd

Comments

@tgd
Copy link
Contributor

tgd commented Jul 12, 2023

There are a number of commented out or unused sections of the code. Removing these can improve readability and maintainability.
@tgd tgd self-assigned this Jul 12, 2023
tgd added a commit that referenced this issue Jul 12, 2023
@tgd
Remove commented out calls to throwExceptionIfClosed (#1386)
c822d1f
tgd added a commit that referenced this issue Jul 13, 2023
@tgd
Remove commented out calls to throwExceptionIfClosed (#1386)
ce8f9af
@tgd tgd changed the title Remove unused code Remove unused code throwExceptionIfClosed Jul 13, 2023
@tgd tgd changed the title Remove unused code throwExceptionIfClosed Remove unused throwExceptionIfClosed calls Jul 13, 2023
tgd added a commit that referenced this issue Jul 13, 2023
@tgd
Remove commented out calls to throwExceptionIfClosed. Fixes #1386
d6fa45d
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Queue-5.24ea22, BOM-2.24ea72

peter-lawrey pushed a commit that referenced this issue Jul 26, 2023
@tgd @peter-lawrey
Remove commented out calls to throwExceptionIfClosed. Fixes #1386 (#1387
6bc63f6 
)
peter-lawrey pushed a commit that referenced this issue Jul 27, 2023
@tgd @peter-lawrey
Remove commented out calls to throwExceptionIfClosed. Fixes #1386 (#1387
0f4b31b 
)
peter-lawrey pushed a commit that referenced this issue Aug 2, 2023
@tgd @peter-lawrey
Remove commented out calls to throwExceptionIfClosed. Fixes #1386 (#1387
7ee1f11 
)
peter-lawrey added a commit that referenced this issue Aug 2, 2023
@peter-lawrey @tgd
@JerryShea @nicktindall
Tune tests (#1399)
8e04c6a 
* Tune running of tests to reduce overhead

* Updating to bom version 2.24ea72

* [maven-release-plugin] prepare release chronicle-queue-5.24ea22

* [maven-release-plugin] prepare for next development iteration

* Reverting back to bom version 2.24ea-SNAPSHOT

* Updating to bom version 2.24ea73

* [maven-release-plugin] prepare release chronicle-queue-5.24ea23

* [maven-release-plugin] prepare for next development iteration

* Reverting back to bom version 2.24ea-SNAPSHOT

* Tune running of tests to reduce overhead

* Remove commented out calls to throwExceptionIfClosed. Fixes #1386 (#1387)

* ignore flaky test #1390

* Don't log a warning when we find a /proc/{pid}/fd/.. file we can't resolve

---------

Co-authored-by: hft-team-city <teamcity@chronicle.software>
Co-authored-by: tgd <tom.dellmann@chronicle.software>
Co-authored-by: Jerry Shea <jerry.shea@chronicle.software>
Co-authored-by: Nick Tindall <nick.tindall@chronicle.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgd tgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgd @hft-team-city