TreeMap encoding Issue

[riadmaouchi]

The wire serialization fail for TreeMap (as object field).

It throws a runtime exception:

java.lang.ClassCastException: java.util.TreeMap cannot be cast to java.util.function.Supplier

This not happened for SortedMap or NavigableMap

[peter-lawrey]

Can you provide a simple unit test to demonstrate this, and we will fix it?

[riadmaouchi]

Thank you for your feedback.

private interface Service {
        void onEventWithTreeMap(EventWithTreeMap event);

        void onEventWithSortedMap(EventWithSortedMap event);
}

private static class EventWithSortedMap extends AbstractMarshallable {
        final SortedMap<String, String> sortedMap;

        private EventWithSortedMap(SortedMap<String, String> sortedMap) {
            this.sortedMap = sortedMap;
        }
}

Please find below a success test using sorted map in event

    // Given
    ChronicleQueue chronicleQueue = SingleChronicleQueueBuilder.binary(eventQueuePath).build();
    final Service service = chronicleQueue.acquireAppender()
            .methodWriter(Service.class);

    // When
    service.onEventWithSortedMap(new EventWithSortedMap(new TreeMap<>()));

    final MethodReader reader = chronicleQueue.createTailer()
            .methodReader(serviceImpl);

    // Then
    assertThat(reader.readOne()).isTrue();

Please find below a failing test using tree map in event

private static class EventWithTreeMap extends AbstractMarshallable {
        final TreeMap<String, String> treeMap;

        private EventWithTreeMap(TreeMap<String, String> treeMap) {
            this.treeMap = treeMap;
        }
}

        // Given
        ChronicleQueue chronicleQueue = SingleChronicleQueueBuilder.binary(eventQueuePath).build();
        final Service service = chronicleQueue.acquireAppender()
                .methodWriter(Service.class);

        // When
        service.onEventWithTreeMap(new EventWithTreeMap(new TreeMap<>()));

        final MethodReader reader = chronicleQueue.createTailer()
                .methodReader(serviceImpl);

        // Then
        assertThat(reader.readOne()).isTrue();

[peter-lawrey]

Added OpenHFT/Chronicle-Wire#40 ᐧ

…

On 10 January 2017 at 13:29, Riad ***@***.***> wrote: Reopened #321 <#321>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#321 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBU8XX-y5at22eBFaagYjfPo-lWZoINks5rQ4epgaJpZM4LfStM> .

[peter-lawrey]

I believe the fault is in Chronicle Wire. ᐧ On 10 January 2017 at 14:22, Peter Lawrey <peter.lawrey@chronicle.software> wrote:

…

Added OpenHFT/Chronicle-Wire#40 ᐧ On 10 January 2017 at 13:29, Riad ***@***.***> wrote: > Reopened #321 <#321>. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#321 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABBU8XX-y5at22eBFaagYjfPo-lWZoINks5rQ4epgaJpZM4LfStM> > . >

[scottkidder]

This can be closed as it appears the issue was fixed in OpenHFT/Chronicle-Wire@c91e7cf

[dpisklov]

Fixed