New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-finalize marshallable fields OpenHFT/Chronicle-Wire#414 #1055

Closed

alamar wants to merge 1 commit into develop from Issue414

Contributor

alamar commented Apr 22, 2022 •

edited

Loading

OpenHFT/Chronicle-Wire#414

minborg reviewed

View reviewed changes

src/test/java/net/openhft/chronicle/queue/MethodReaderObjectReuseTest.java Outdated

@@ @@ -60,7 +60,7 @@ interface Pinger { @@
                   static class PingDTO extends SelfDescribingMarshallable {
                       static int constructionCounter, constructionExpected;
-                      final Bytes<?> bytes = Bytes.allocateElasticOnHeap();
+                      Bytes<?> bytes = Bytes.allocateElasticOnHeap();

Contributor

minborg Apr 25, 2022

Not sure how Bytes works. It is mutable but may have size constraints. If a final Byte<?> is declared, one must make sure it can hold any conceivable value in the application at hand?


          De-finalize marshallable fields OpenHFT/Chronicle-Wire#414

43c1c0e

alamar force-pushed the Issue414 branch from 5acaca2 to 43c1c0e Compare

April 25, 2022 14:33

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

alamar closed this

alamar deleted the Issue414 branch

April 21, 2023 11:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment