-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated methods #1557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgd
approved these changes
Apr 9, 2024
JerryShea
approved these changes
Apr 9, 2024
yevgenp
approved these changes
Apr 9, 2024
nicktindall
approved these changes
Apr 9, 2024
JerryShea
reviewed
Apr 9, 2024
@@ -814,7 +761,6 @@ public BufferMode readBufferMode() { | |||
* When readBufferMode is set to {@code Asynchronous}, reads from the ring buffer. This requires | |||
* that {@link #writeBufferMode()} is also set to {@code Asynchronous}. | |||
* See also {@link #bufferCapacity()} | |||
* See also {@link #bufferBytesStoreCreator()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should instead see also asyncBufferCreator
JerryShea
reviewed
Apr 9, 2024
@@ -792,7 +740,6 @@ public BufferMode writeBufferMode() { | |||
* When writeBufferMode is set to {@code Asynchronous}, uses a ring buffer to buffer appends, excerpts are written to the | |||
* Chronicle Queue using a background thread. | |||
* See also {@link #bufferCapacity()} | |||
* See also {@link #bufferBytesStoreCreator()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as below
peter-lawrey
added a commit
that referenced
this pull request
Apr 15, 2024
* Remove deprecated methods * remove deprecated SuppressWarnings
peter-lawrey
added a commit
that referenced
this pull request
Apr 29, 2024
* Remove deprecated methods * remove deprecated SuppressWarnings
peter-lawrey
added a commit
that referenced
this pull request
May 20, 2024
* Remove deprecated methods * remove deprecated SuppressWarnings
peter-lawrey-admin
pushed a commit
that referenced
this pull request
May 28, 2024
* Initial branch of x.26 * Review deprecated methods, change build to error on deprecation (#1551) * Review deprecated methods, change build to error on deprecation * <release>8</release> * Fix compilation on Java 21 * Don't use OS.getUsrDir() yet * Use release 8 only for Java 11+ * Turn off implicit annotation processing * Turn off implicit annotation processing * Add expected exception * Add ignored error * Use a common configuration for the compiler-plugin where deprecation … (#1553) * Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail * Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail * Deprecate RollCycles legacy code. * Deprecate due x.26. * Tidy up compiler setting and some warnings * Reduce the number of raw types * remove deprecated MultiQueue classes * Remove deprecated methods (#1557) * Remove deprecated methods * remove deprecated SuppressWarnings * resolve Javadoc issues * Added fail on warning lint for Javadoc, and rawtypes fixes for Bytes (#1558) * import net.openhft.chronicle.wire.Sequence * serializable warning suppressed * Fix warnings following rebase with develop * Add methods for clear() and emptyHistory() to reduce direct references to VanillaMessageHistory * Fix warnings following rebase with develop * PretouchUtil deprecated * PretouchUtil deprecated * Fix deprecation issues in Java 17+ * Fix newlines * redundant newline * redundant spaces * </p> tag in javadoc not allowed * Javadoc fixes * Javadoc fixes * TimeoutPauser -> YieldingPauser * ChronicleQueue#createPretoucherEventHandler * ChronicleReader suppress empty message. Closes #1579 * TimeoutPauser -> YieldingPauser * parent poms -> x.26.0 * Where marked for removal, also mark for deprecation --------- Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software> Co-authored-by: Jerry Shea <jerry.shea@chronicle.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.