Add methods #474
Merged
Add methods #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-lawrey
approved these changes
May 17, 2022
peter-lawrey
added a commit
that referenced
this pull request
Jun 6, 2022
* update. * update. * Add replay method and tests. * Added a test for the microservice * Add Javadoc. Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software> Co-authored-by: Peter K Lawrey <peter.lawrey@higherfrequencytrading.com>
peter-lawrey
added a commit
that referenced
this pull request
Jun 6, 2022
* Remove addPadding(true) for useTextDocuments() #471 * Remove addPadding(true) for useTextDocuments() #471 * Improve handling of null in a sequence #471 * rename broken test - check behaviour of MethodIds in generated MethodReader * sonar code smells * deprecate VanillaMethodReaderBuilder.ignoreDefaults * deprecate VanillaMethodWriterBuilder.methodWriterInterceptorReturns * Updating to bom version 2.23ea44 * [maven-release-plugin] prepare release chronicle-wire-2.23ea9 * [maven-release-plugin] prepare for next development iteration * Reverting back to bom version 2.23ea-SNAPSHOT * Infinite message loop is possible with dontWriteHistoryForEventsWithNoOutput=false, closes ChronicleEnterprise/Chronicle-Services-Enterprise#330 * For functions with with primitive return values, make generated method writers behave the same as Proxy method writers * Enhance ChainedMethodsTest for old-style proxies and also generated code * un-Ignore tests * Updating to bom version 2.23ea45 * [maven-release-plugin] prepare release chronicle-wire-2.23ea10 * [maven-release-plugin] prepare for next development iteration * Reverting back to bom version 2.23ea-SNAPSHOT * fix generated code method writer for generic return types * Add methods (#474) * update. * update. * Add replay method and tests. * Added a test for the microservice * Add Javadoc. Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software> Co-authored-by: Peter K Lawrey <peter.lawrey@higherfrequencytrading.com> * Added a YamlTester interface to simplify running YAML based tests #475 * Added a YamlTester interface to simplify running YAML based tests #475 * Added a YamlTester interface to simplify running YAML based tests #475 * Added a YamlTester interface to simplify running YAML based tests #475 * Updating to bom version 2.23ea49 * [maven-release-plugin] prepare release chronicle-wire-2.23ea12 * [maven-release-plugin] prepare for next development iteration * Reverting back to bom version 2.23ea-SNAPSHOT * Updating parent POM (automated) * Ignore some packages in SOT (#479) * Ignore flappy test #482 * Ignore flappy test #482 * Remove delegate from generated MethodReader to proxied MethodReader. Support defaultParselet. Warnings for users of deprecated methods. Better reporting of method writer compilation failure. Warning that proxies will be dropped in x.25 * Updating parent POM (automated) * Un-pin the binary-compatibility-enforcer version * Flaky test fix closes #486 * Remove addPadding(true) for useTextDocuments() #471 * Remove addPadding(true) for useTextDocuments() #471 Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software> Co-authored-by: Jerry Shea <jerry.shea@chronicle.software> Co-authored-by: hft-team-city <teamcity@chronicle.software> Co-authored-by: Ivan Rakov <ivan.glukos@gmail.com> Co-authored-by: Forough Goudarzi <forough.goudarzi@chronicle.software> Co-authored-by: Per-Åke Minborg <minborg@speedment.com> Co-authored-by: Nick Tindall <nick@tindall.id.au> Co-authored-by: Ilya Kaznacheev <ilya.kaznacheev@chronicle.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required methods and tests for article https://docs.google.com/document/d/1M4KyV98CqgjRWFz5Mst6b_GtO_7GSwyYg--YH-EBSdI/edit#heading=h.byzbzwt7gnfb