X.26 lint all #869
Merged
X.26 lint all #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenp
approved these changes
Apr 4, 2024
Comment on lines
+3566
to
3569
| if (true) | ||
| throw e; | ||
| Jvm.warn().on(getClass(), "Unknown class (" + sb + "), perhaps you need to define an alias", e); | ||
| return null; |
There was a problem hiding this comment.
This does not make sense, last 2 lines are unreachable. They should be deleted?
peter-lawrey
added a commit
that referenced
this pull request
Apr 10, 2024
* Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes") * Minor fixes * Narrow the SuppressWarnings * Add -Xlint:all,-options as default compiler * Fix deprecated field
peter-lawrey
added a commit
that referenced
this pull request
Apr 15, 2024
* Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes") * Minor fixes * Narrow the SuppressWarnings * Add -Xlint:all,-options as default compiler * Fix deprecated field
peter-lawrey
added a commit
that referenced
this pull request
Apr 29, 2024
* Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes") * Minor fixes * Narrow the SuppressWarnings * Add -Xlint:all,-options as default compiler * Fix deprecated field
peter-lawrey
added a commit
that referenced
this pull request
May 28, 2024
* Initial branch of x.26 * Error on deprecated (#862) * Review deprecated methods, change build to error on deprecation * <release>8</release> * Fix compilation on Java 21 * Don't use UnsafeText here * Don't use UnsafeText here * Use release 8 only for Java 11+ * MacOSX issue on modification date * Clarify why the @deprecated is commented out. * Clarify why the @deprecated is commented out. * Deprecate due x.26 * reduced compatibility * Remove se.eris.notnull.instrument * Wire to 2.26ea0 * X.26 common compile flags (#865) * Initial branch of x.26 * Error on deprecated (#862) * Review deprecated methods, change build to error on deprecation * <release>8</release> * Fix compilation on Java 21 * Don't use UnsafeText here * Don't use UnsafeText here * Use release 8 only for Java 11+ * MacOSX issue on modification date * Clarify why the @deprecated is commented out. * Clarify why the @deprecated is commented out. * Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail * Tidy up compiler setting and some warnings * X.26 lint all (#868) * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes") * Minor fixes * Narrow the SuppressWarnings * X.26 lint all (#869) * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * Add -Xlint:all,-options as default compiler * @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes") * Minor fixes * Narrow the SuppressWarnings * Add -Xlint:all,-options as default compiler * Fix deprecated field * Fix deprecated field * Tidy up code base * resolve merge issues * resolve Javadoc issues * Added fail on warning lint for Javadoc, and rawtypes fixes for Bytes (#872) * serializable warning suppressed * Fix Javadoc formatting * Fix warnings following rebase with develop * Add methods for clear() and emptyHistory() to reduce direct references to VanillaMessageHistory * Fix warnings following rebase with develop * removed unwanted cast * updated test * FIX deprecation issues in Java 17+ * revert change * Fix newlines * </p> tag in javadoc not allowed * Don't try to serialize a thread (#893) * Using reflection to unmonitor a reference results in errors in Java 17 Fixes OpenHFT/Chronicle-Core#656 * Fix warnings following rebase with develop * Add methods for clear() and emptyHistory() to reduce direct references to VanillaMessageHistory * Handle deprecated members * parent poms -> x.26.0 * Where marked for removal, also mark for deprecation --------- Co-authored-by: yevgen.pavlenko <yevgen.pavlenko@chronicle.software> Co-authored-by: Rob Austin <rob.austin@boundedbuffer.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.