Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "bootstrap class path not set in conjunction with -source 8". #222

Closed
wants to merge 1 commit into from
Closed

Prevent "bootstrap class path not set in conjunction with -source 8". #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion chronicle-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>net.openhft</groupId>
<artifactId>root-parent-pom</artifactId>
<version>1.25.4</version>
<version>1.25.5-SNAPSHOT</version>
<relativePath />
</parent>
<modelVersion>4.0.0</modelVersion>
Expand Down
2 changes: 1 addition & 1 deletion java-parent-pom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<groupId>net.openhft</groupId>
<artifactId>root-parent-pom</artifactId>
<version>1.25.4</version>
<version>1.25.5-SNAPSHOT</version>
<relativePath />
</parent>

Expand Down
21 changes: 21 additions & 0 deletions root-parent-pom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,27 @@
</plugins>
</build>
</profile>
<profile>
<!-- prevents "bootstrap class path not set in conjunction with -source 8" -->
<id>set-compiler-release-java9</id>
<activation>
<jdk>[9,21]</jdk>
Copy link
Contributor

@JerryShea JerryShea Apr 2, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't ] be ) so as to exclude 21 from this range?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy/paste from FIX. Done by you AFAIR. :)
I did not test it. Feel free to adjust.
I don't see any support from @peter-lawrey anyway. So it's up to you to decide what to do with the PR.

</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
<profile>
<!-- -source 8 no longer supported in Java 21" -->
<id>set-compiler-release-java21</id>
<activation>
<jdk>[21,)</jdk>
</activation>
<properties>
<compiler.release>11</compiler.release>
<maven.compiler.release>11</maven.compiler.release>
</properties>
</profile>
<profile>
<id>java11</id>
<activation>
Expand Down
2 changes: 1 addition & 1 deletion third-party-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<groupId>net.openhft</groupId>
<artifactId>root-parent-pom</artifactId>
<version>1.25.4</version>
<version>1.25.5-SNAPSHOT</version>
<relativePath />
</parent>

Expand Down