-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low image quality on exports #353
Comments
I expanded the experiment by installing fedora 37 in a VM and producing screenshots from the vm and then mounting the qcow2 image, chrooting into it and producing new screenshots. As far as I know, the only thing from alpine 3.17 being used in the chroot case is the wayland compositor (sway) and the kernel. The 4 images are attached. |
@espindola |
I also have HiDPI monitor 3840x2112 and the same problem. |
I already tried this long ago. Unfortunately this is not possible with the OpenGL graphics. The option for line width doesn't work - the width stays always "1". |
My laptop resolution is 3200x1800, but sway is configured to scale it by 2 (" scale 2" in the config file). I did the hack of multiplying by 2 by adding
I should probably try a KDE or Gnome session to compare. Will hopefully have that tonight. |
Thinks look OK on my desktop, which has a 4K display (but is running arch, which has a newer version of sway). |
Are you using Wayland or X? Which compositor? |
Currently X11, Kwin. |
@espindola What are your values of sw and sh before you scale them? About 3200x1800 or 1600x900 (scale2)?
|
I got: screenshot size: 1596 x 841 |
Ok, you get the downscaled size and upscale it to the correct 1:1 size. |
Given that the image looks OK when drawing directly (not writing to the QPixmap), Qt must know this somehow (see #353 (comment)) , but I don't know where to look. |
Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
Please try the latest unstable - set scale factor in menu |
The resolution is fixed, but some lines are still broken. Compare with #353 (comment) |
Which value did you set? 2? |
Yes, 2. |
strange, then it should give the same result as your
But now another shot in the dark -> new unstable (1e7788b) |
I am using f4d31c4
The attached screenshots of demo mode illustrate the problems. The first one is that the resolution is low. It seems to have something to do with HiDPI displays. I was able to hack it locally by multiplying the width and heighth by 2, but I am not sure what the proper fix is.
The other problem is that some lines are broken.
Everything looks good when running OpenHantek, it is only the exported pngs that are bad.
Computer environment (please complete the following information):
I am running alpine linux 3.17, but I have been able to reproduce this with a debian stable chroot. Somehow the issue is not present on arch linux with version 3.3.2.1-1.
Given that it fails with a debian stable chroot, I suspect that somehow the sway or kernel version is relevant:
linux-lts-5.15.95-r0
sway-1.7-r4
Intel Corporation HD Graphics 620 (rev 02)
Graphic: 4.6 (Compatibility Profile) Mesa 22.2.5 - GLSL version 1.20
qt5-qtbase-5.15.6_git20221010-r0
gcc (Alpine 12.2.1_git20220924-r4) 12.2.1 20220924
Scope device (please complete the following information):
demo mode
The text was updated successfully, but these errors were encountered: