Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve previous data on create datatype form error #1087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madprime
Copy link
Member

Description

When creating a new DataType on the site, I produced a form error – and all my edits were lost (including extensive text). When rejected, a form should reload filled with the information people entered when submitting – losing this can be frustrating, and lead to errors.

I checked the "edit" form and it's fine – just the "create" form. This update adds the template to load submitted information into the form, if it exists.

Testing

  • passed automated testing locally
  • ran locally to test manually:
    • reproduced bug
    • checked all fields are now preserved on form error & reload
    • checked form submission works once errors are corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant