Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkg 'Too many open files' errors #50

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Conversation

pyhalov
Copy link

@pyhalov pyhalov commented Jul 4, 2018

…ease soft fd limit

24681766 pkg cli tools should use pkgdefs constants

…ease soft fd limit

24681766 pkg cli tools should use pkgdefs constants
@pyhalov
Copy link
Author

pyhalov commented Jul 5, 2018

@citrus-it Have you seen this issue? I mean cli.t_pkg_linked.TestPkgLinkedScale.test_li_scale failure with 'Too many open files'.
I see two modes of failure

  1. pkg in parent image dies with 'pkg: An error was encountered while attempting to store information about the current operation in client history' (when ulimit -n is 65536). If we raise ulimit to 128000 (or unlimited) or apply 'Try to remove limit on number of open files completely' patch, this stage finishes fine.
  2. pkgs in child images die with 'Failed 'metadata update' for child image (system:img184) at path: /tmp/ips.test.27843/0/image184/: [Errno 24] Too many open files'. So far not sure what to do with this failure.

And yes, I've seen the failure in real life when we have a system with ~ 100 zones and do pkg update -r.

@citrus-it
Copy link

No, but the test is skipped on our build VMs as they only have 8GiB of RAM..

Can you work around the failure with -C 50 or whatever to pkg update? If so, you might be interested in our patch that adds pkg set-property recursion-concurrency omniosorg/pkg5@b99764b

@pyhalov
Copy link
Author

pyhalov commented Jul 5, 2018

No, '-C x' doesn't help

@pyhalov pyhalov force-pushed the rlimit branch 2 times, most recently from cefe028 to 30261d3 Compare August 30, 2018 19:00
@pyhalov
Copy link
Author

pyhalov commented Aug 31, 2018

BASELINE MISMATCH: The following results didn't match the baseline.
----------------------------------------------------------------------
cli.t_pkgdep.py TestPkgdepBasics.test_PEP_3149: fail
cli.t_pkgdep.py TestPkgdepBasics.test_bug_11805: error
cli.t_pkgdep.py TestPkgdepBasics.test_bug_13059: fail
cli.t_pkgdep.py TestPkgdepBasics.test_output: error
cli.t_pkgdep.py TestPkgdepBasics.test_python_combinations: error
cli.t_pkg_info.py TestPkgInfoBasics.test_ranked: fail
cli.t_pkg_linked.py TestPkgLinkedRecurse.test_recursive_variant: fail
----------------------------------------------------------------------

This heals cli.t_pkg_linked.py TestPkgLinkedScale.test_li_scale test.

@pyhalov pyhalov changed the title 21866339 pkgrepo (and other pkg tools that need many fds) should incr… Fix pkg 'Too many open files' errors Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants