FrameListener pullrequest #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 21, 2014 16:33
added the frame map definition to header, so that a program using libfreenect2 does not have to include the frame listener implementation.
Config is read from the Config struct. Removed unused variables from opencl code.
added a cmake variable for the depends dir.
|
I would like to keep FrameListener as an interface with a single method |
|
That is also a solution. As long as the implementation gets hidden everything is fine. |
christiankerl
added a commit
to christiankerl/libfreenect2
that referenced
this pull request
Sep 28, 2014
…OpenKinect#48\n - added non-blocking method to check if all frames are available\n - added timed wait function if compiled with c++0x or c++11
christiankerl
added a commit
to christiankerl/libfreenect2
that referenced
this pull request
Sep 28, 2014
- implementation using pimpl - fixes OpenKinect#48 - added non-blocking method to check if all frames are available - fixes OpenKinect#56 - added timed wait function if compiled with c++0x or c++11
|
included in PR #57 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the definition of the FrameMap to the frame_listener.hpp and extended to FrameListener to have prototypes of all needed methods, that are implemented in the actual FrameListener implementation. Also I added a static method for creating a new FrameListener.
With this changes the projects that are using libfreenect2 only have to include the libfreenect2.hpp and the frame_listener.hpp. They do not have to include the frame_listener_impl.h anymore.