Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrarily nested profiles #537

Open
fredemmott opened this issue Mar 19, 2024 · 1 comment
Open

Support arbitrarily nested profiles #537

fredemmott opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement Enhancement to an existing feature

Comments

@fredemmott
Copy link
Collaborator

fredemmott commented Mar 19, 2024 •
edited
Loading

Currently all profiles inherit settings from the default profile, unless they override that setting. Deeper nesting should be supported.
@fredemmott fredemmott added the enhancement Enhancement to an existing feature label Mar 19, 2024
@fredemmott fredemmott mentioned this issue Mar 19, 2024
Open
fredemmott added a commit that referenced this issue Apr 13, 2024
@fredemmott
Fix inheritance of v1.7+ views
49d3a68 
fixes #558

refs #537
refs #312

Tested with:

1. delete OpenKNebeoard's saved games folder
2. Install OpenKneeboard v1.6.4
3. Enable additional profiles
4. Create a new profile
5. enable dual kneeboards in the new profile
6. switch backc to default profile
7. Close OpenKneeboard v1.6.4
8. Start this version
9. Make sure that the default profile has one view, the second has two
10. Add a new profile
11. Make sure it has one view
12. Add an additional viwe  to the default profile
13. make sure the latest additional profile has the new view too
14. delete the new view from the additoinal profile
15. make sure it's still in the default profile
16. Repeat, but use 2 kneeboards in the default profile and 1 in the first test profile
fredemmott added a commit that referenced this issue Apr 14, 2024
@fredemmott
Fix inheritance of v1.7+ views
738cba9 
fixes #558

refs #537
refs #312

Tested with:

1. delete OpenKNebeoard's saved games folder
2. Install OpenKneeboard v1.6.4
3. Enable additional profiles
4. Create a new profile
5. enable dual kneeboards in the new profile
6. switch backc to default profile
7. Close OpenKneeboard v1.6.4
8. Start this version
9. Make sure that the default profile has one view, the second has two
10. Add a new profile
11. Make sure it has one view
12. Add an additional viwe  to the default profile
13. make sure the latest additional profile has the new view too
14. delete the new view from the additoinal profile
15. make sure it's still in the default profile
16. Repeat, but use 2 kneeboards in the default profile and 1 in the first test profile
@Ysasmendi
Copy link

I saw this issue when I was about to make a suggestion, which is allowing different profiles nested within plane profiles.

The purpose is to be able to set the kneeboard position once per plane, then have different profiles with different sets of documents on each one, if this makes sense.

Thanks

@fredemmott fredemmott changed the title Support nested profiles Support arbitrarily nested profiles Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature
Projects
v1.9
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fredemmott @Ysasmendi