Update guide to use JSON-B instead of Jackson #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 1, 2018 11:04
yeekangc
requested changes
Jun 29, 2018
README.adoc
Outdated
| :page-duration: 20 minutes | ||
| :page-releasedate: 2017-10-04 | ||
| :page-duration: 25 minutes | ||
| :page-releasedate: 2018-06-01 |
There was a problem hiding this comment.
Need to be updated to when the guide will be refreshed.
README.adoc
Outdated
| :page-duration: 20 minutes | ||
| :page-releasedate: 2017-10-04 | ||
| :page-duration: 25 minutes | ||
| :page-releasedate: 2018-06-01 | ||
| :page-description: Learn how to consume a RESTful web service |
There was a problem hiding this comment.
Add "in Java using JSON-B and JSON-P" to the end.
| //or custom constructor can be used | ||
| this.title = title; | ||
| this.artistName = artistName; | ||
| this.totalTracks = totalTracks; |
There was a problem hiding this comment.
Alignment or extra whitespaces need to be fixed?
| @JsonbProperty("albums") Album albums[]) { | ||
| //or custom constructor can be used | ||
| this.name = name; | ||
| this.albums = albums; |
There was a problem hiding this comment.
Alignment or whitespaces to be fixed?
| @@ -22,6 +22,7 @@ | |||
| import javax.ws.rs.core.UriInfo; | |||
|
|
|||
| import io.openliberty.guides.consumingrest.model.Artist; | |||
| //import io.openliberty.guides.consumingrest.Consumer; | |||
|
@KyleAure, looks like the latest changes are here including the fixes for #26. Kyle, can you please doubly confirm? @JunyiSun, can you doubly confirm that we have this PR tested and both the guide and code check out? Then, we can approve, merge and ask @kinueng to refresh the site for us. @evelinec, FYI. |
yeekangc
approved these changes
Jul 2, 2018
|
We are good to go. Thank you, @KyleAure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining changes requested at the end of the previous pull request here: #20