-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Semeru Cloud Compiler for InstantOn #438
Comments
Running semeru compiler with open-liberty operator and instanton on OCP threw the follwoing error.
@mpirvu has added a fix in eclipse-openj9/openj9#17797 to fix this issue. The change will be present in OpenJ9 0.41.0 which is expected to GA on Oct 17. Will test again using the changes done by Marius. |
Operator changes were delivered with WebSphere and Open Liberty Operators 1.3.0 |
@anjumfatima90 / @tjwatson This has been delivered with Liberty Operator 1.3.0. The OpenJ9 fix is also now available with Liberty images. Please validate and close. Thank you. |
Validated the semeru compiler using open liberty operator. Got the following logs with no errors. JITServer reported:
and the client reported:
|
Feature Request
Is your feature request related to a generic (non-Open Liberty) problem?
If so, please open an issue with the upstream Operator, which gets pulled into this Operator.
No
Is your feature request related to a problem?
A clear and concise description of what the problem is. Example: "I have an issue when (...)"
No
Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.
When running an Open Liberty InstantOn application the JVM process is restored in-container from a process checkpoint taken at container build time. The restored Java process will not recognized the JVM options specified in
OPENJ9_JAVA_OPTIONS
that get set by the operator at: https://github.com/OpenLiberty/open-liberty-operator/blob/6bed003a36648be6477635b265a890b45dd01b1e/controllers/semeru_compiler.go#LL551-L554C24The CRIU support for Semeru did add a new environment variable that can be used to modify JVM arguments when the JVM process is restored called
OPENJ9_RESTORE_JAVA_OPTIONS
. If the operator sets this environment variable to the options it sets to enable the cloud compiler (-XX:+UseJITServer -XX:+JITServerLogConnections -XX:JITServerAddress=%v -XX:JITServerSSLRootCerts=%v
) then the JVM will process these options on restore and enable the use of the cloud compiler with Liberty InstantOn.It should be safe to set this environment variable regardless of if InstantOn is being used or not. For "normal" Liberty launches without InstantOn this environment variable will be ignored.
The text was updated successfully, but these errors were encountered: