Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of runIfQueueFull should refer to relation with maxPolicy #1232

Closed
njr-11 opened this issue Dec 6, 2017 · 0 comments · Fixed by #1233
Closed

Description of runIfQueueFull should refer to relation with maxPolicy #1232

njr-11 opened this issue Dec 6, 2017 · 0 comments · Fixed by #1233
Assignees
@njr-11
Labels
bug This bug is not present in a released version of Open Liberty release-18.0.0.1 team:Zombie Apocalypse
Milestone
[Iteration 17.25]...

Comments

@njr-11
Copy link
Contributor

njr-11 commented Dec 6, 2017

Externals review comment: In the concurrencyPolicy configuration, runIfQueueFull attribute description needs to refer to its relation with maxPolicy attribute.

Note that this is already done in the opposite direction: maxPolicy description already refers to runIfQueueFull, so the only update being asked for is to the runIfQueueFull description.
@njr-11 njr-11 added bug This bug is not present in a released version of Open Liberty team:Zombie Apocalypse labels Dec 6, 2017
@njr-11 njr-11 self-assigned this Dec 6, 2017
njr-11 added a commit to njr-11/open-liberty that referenced this issue Dec 6, 2017
@njr-11
Issue OpenLiberty#1232 runIfQueueFull description should refer to max…
f2b439d 
…Policy
@njr-11 njr-11 mentioned this issue Dec 6, 2017
Merged
njr-11 added a commit to njr-11/open-liberty that referenced this issue Dec 6, 2017
@njr-11
Issue OpenLiberty#1232 code review comment
8a18a9e
njr-11 added a commit to njr-11/open-liberty that referenced this issue Dec 8, 2017
@njr-11
Issue OpenLiberty#1232 address review comments from ID review
fbb7441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njr-11 njr-11

Labels
bug This bug is not present in a released version of Open Liberty release-18.0.0.1 team:Zombie Apocalypse
Projects
None yet
Milestone
[Iteration 17.25] December 4 - Decemb...
Development

Successfully merging a pull request may close this issue.

runIfQueueFull description should refer to maxPolicy njr-11/open-liberty
2 participants
@njr-11 @LibbyBot