Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify use of responseType attribute #8830

Merged

Conversation

brutif
Copy link
Contributor

@brutif brutif commented Sep 3, 2019

resolves #8808

@LibbyBot
Copy link

LibbyBot commented Sep 3, 2019

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.security.openidconnect.client/resources/OSGI-INF/l10n/metatype.properties

@brutif
Copy link
Contributor Author

brutif commented Sep 3, 2019

#build

@LibbyBot
Copy link

LibbyBot commented Sep 3, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_zFpdsM6EEemo7shcvMe-cQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Sep 4, 2019

@LibbyBot
Copy link

LibbyBot commented Sep 4, 2019

The build brutif-8830-20190904-0012
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_zFpdsM6EEemo7shcvMe-cQ
completed successfully!

@brutif brutif requested a review from ayoho September 4, 2019 13:54

grantType.authorization_code=Authorization code grant type
grantType.implicit=Implicit grant type

responseType=Response type
responseType.desc=Specifies the required response type for this client.
responseType.desc=Specifies the response requested from the provider, either an authorization code or implicit flow tokens.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably prefer to say "Specifies the response type that is requested from the provider"

Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request for clarification, thanks

@@ -105,13 +105,13 @@ jwkClientSecret=JWK client password
jwkClientSecret.desc=Specifies the client password to include in the basic authentication scheme of the JWK request.

grantType=Grant type
grantType.desc=Specifies the grant type to use for this client.
grantType.desc=Specifies the grant type to use for this client. Use of the responseType attribute is preferred instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of what? The inout that generated this meesage?

@andrea-pichler
Copy link

No message review requested from L2

@brutif brutif merged commit af1e932 into OpenLiberty:integration Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC RP does notHTTP Auth header as containing a valid OIDC id_token
5 participants