Skip to content

Commit

Permalink
Add some potential TODO for another way to track devices without serial
Browse files Browse the repository at this point in the history
  • Loading branch information
peternewman committed Feb 3, 2024
1 parent 6a6b42e commit 949ce94
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions plugins/usbdmx/AVLdiyD512Factory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ bool AVLdiyD512Factory::DeviceAdded(
// Some AVLdiy devices don't have serial numbers. Since there isn't another
// good way to uniquely identify a USB device, we only support one of these
// types of devices per host.
// TODO(Peter): We could instead use the device & bus number (like the
// Eurolite plugin). You could use more than one device, but the patch
// wouldn't follow if you plugged it into a different port
if (info.serial.empty()) {
if (m_missing_serial_number) {
OLA_WARN << "Failed to read serial number or serial number empty. "
Expand Down
3 changes: 3 additions & 0 deletions plugins/usbdmx/AnymauDMXFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ bool AnymauDMXFactory::DeviceAdded(
// Some Anyma devices don't have serial numbers. Since there isn't another
// good way to uniquely identify a USB device, we only support one of these
// types of devices per host.
// TODO(Peter): We could instead use the device & bus number (like the
// Eurolite plugin). You could use more than one device, but the patch
// wouldn't follow if you plugged it into a different port
if (info.serial.empty()) {
if (m_missing_serial_number) {
OLA_WARN << "Failed to read serial number or serial number empty. "
Expand Down
3 changes: 3 additions & 0 deletions plugins/usbdmx/DMXCreator512BasicFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ bool DMXCreator512BasicFactory::DeviceAdded(
// vendor and product ids. Also, since DMXCreator 512 Basic devices don't have
// serial numbers and there is no other good way to uniquely identify a USB
// device, we only support one of these types of devices per host.
// TODO(Peter): We could instead use the device & bus number (like the
// Eurolite plugin). You could use more than one device, but the patch
// wouldn't follow if you plugged it into a different port
if (info.serial.empty()) {
if (m_missing_serial_number) {
OLA_WARN << "We can only support one device without a serial number.";
Expand Down
3 changes: 3 additions & 0 deletions plugins/usbdmx/ScanlimeFadecandyFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ bool ScanlimeFadecandyFactory::DeviceAdded(
// Fadecandy devices may be missing serial numbers. Since there isn't another
// good way to uniquely identify a USB device, we only support one of these
// types of devices per host.
// TODO(Peter): We could instead use the device & bus number (like the
// Eurolite plugin). You could use more than one device, but the patch
// wouldn't follow if you plugged it into a different port
if (info.serial.empty()) {
if (m_missing_serial_number) {
OLA_WARN << "Failed to read serial number or serial number empty. "
Expand Down

0 comments on commit 949ce94

Please sign in to comment.