Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we don't return unsuitable indicies or hardware types via RDM #1478

Closed
peternewman opened this issue Aug 21, 2018 · 3 comments
Closed

Comments

@peternewman
Copy link
Member

See the NetworkTester contents of the test suite here:
#1473 (comment)

From the standard (regarding index):

The interface identifiers returned shall range from 1 to 0xFFFFFF00.

Also add a test as a companion too.

@peternewman
Copy link
Member Author

peternewman commented Oct 26, 2018

Regarding hardware types, the standard says:

The Interface Hardware Type field identifies the underlying hardware of the interface. The
values are defined in [ARP-PARAMETERS] under the 'Hardware Types' section.

So aside from working harder to fetch others (which we've already done in #1493), it's probably not worth doing anything more on that side.

@peternewman
Copy link
Member Author

Other bits covered in #1504

@peternewman
Copy link
Member Author

Closed in #1504 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant