Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enttec USB Pro MK2 FW 4.15 RDM Discovery #1631

Closed
peternewman opened this issue Apr 15, 2020 · 3 comments · Fixed by #1646
Closed

Enttec USB Pro MK2 FW 4.15 RDM Discovery #1631

peternewman opened this issue Apr 15, 2020 · 3 comments · Fixed by #1646
Assignees
@peternewman
Labels
Component-Plugin Difficulty-Medium Language-C++ Type-DeviceSupport
Milestone
0.10.8

Comments

@peternewman
Copy link
Member

When running against firmware 4.5 (and possibly earlier) on a Mk 2, there appears to be no timeout on DUB, which causes discovery to not start, let alone complete.

We need to detect the firmware version and not wait for the DUB. Ideally also need to check earlier versions, I'm not sure it's ever worked on a Mk 2 as I don't know if I did RDM discovery when I added support for it?
@peternewman peternewman added this to the 0.10.8 milestone Apr 15, 2020
@peternewman peternewman mentioned this issue Jun 17, 2020
Open
@peternewman
Copy link
Member Author

See also #1644

@peternewman peternewman linked a pull request Sep 2, 2020 that will close this issue
First proper attempt to fix Enttec DMX USB Pro Mk 2 #1631 without breaking it for older devices #1646
Merged
@peternewman
Copy link
Member Author

When running against firmware 4.5 (and possibly earlier) on a Mk 2

I think I meant 4.15 as that's what I put in the title and #1644 is for 4.17 at least. Also 4.5 isn't out yet!

peternewman added a commit that referenced this issue Sep 16, 2020
@peternewman
Merge pull request #1646 from peternewman/0.10-c11-compat
012cfaf 
 First proper attempt to fix Enttec DMX USB Pro Mk 2 #1631 without breaking it for older devices
@peternewman
Copy link
Member Author

A device running 4.14 ran discovery fine and I didn't notice the additional log messages in it.

@peternewman peternewman self-assigned this Oct 26, 2020
@peternewman peternewman mentioned this issue Dec 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peternewman peternewman

Labels
Component-Plugin Difficulty-Medium Language-C++ Type-DeviceSupport
Projects
None yet
Milestone
0.10.8
1 participant
@peternewman