Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ola_rdm_get.py throws AttributeError when issuing a "get parameter_description" #884

Closed
rmull opened this issue Aug 26, 2015 · 3 comments
Closed

Comments

@rmull
Copy link

rmull commented Aug 26, 2015

I am getting a Python (2.7.9) traceback when issuing the following command:

./ola_rdm_get.py -u 1 --uid 3638:12000001 parameter_description

I get this in interactive mode (-i) as well, which I was using in an attempt to be able to specify the PID of the parameter I wanted described. Here is the traceback text:

Traceback (most recent call last):
  File "./ola_rdm_get.py", line 485, in <module>
    main()
  File "./ola_rdm_get.py", line 481, in main
    controller.onecmd('%s %s' % (request_type, ' '.join(args)))
  File "/usr/lib/python2.7/cmd.py", line 221, in onecmd
    return func(arg)
  File "./ola_rdm_get.py", line 248, in do_get
    self.GetOrSet(PidStore.RDM_GET, line)
  File "./ola_rdm_get.py", line 318, in GetOrSet
    args, help_string = pid.GetRequestDescription(request_type)
  File "/usr/lib/python2.7/dist-packages/ola/PidStore.py", line 204, in GetRequestDescription
    return group.GetDescription()
  File "/usr/lib/python2.7/dist-packages/ola/PidStore.py", line 849, in GetDescription
    output.append(atom.GetDescription(indent=2))
  File "/usr/lib/python2.7/dist-packages/ola/PidStore.py", line 366, in GetDescription
    return ('%s%s: <%s> %s' % (indent, self.name, self._GetAllowedRanges(),
  File "/usr/lib/python2.7/dist-packages/ola/PidStore.py", line 393, in _GetAllowedRanges
    (self._AccountForMultiplier(range.min),
AttributeError: 'UInt16' object has no attribute '_AccountForMultiplier'
@rmull
Copy link
Author

rmull commented Aug 26, 2015

Quick update - if I add an extra argument formatted in base-10, I instead get the following:

$ ./ola_rdm_get.py -u 1 -d 2 --uid 3638:12000001 parameter_description 32999
Can't send GET PARAMETER_DESCRIPTION to non root sub devices

Hexadecimal and non-existent args trigger the traceback.

@nomis52
Copy link
Member

nomis52 commented Aug 26, 2015

Ah I see the problem, b1b6606 renamed the _AccountForMultiplier() method but didn't fix all the callees.

@peternewman do you mind fixing this one.

@peternewman peternewman self-assigned this Aug 26, 2015
nomis52 added a commit that referenced this issue Aug 27, 2015
Correct the function name of _AccountForMultiplier, closes #884
@peternewman
Copy link
Member

Sorry, my sloppy coding, now sorted and will be in 0.9.8 (when I cherry pick shortly).

peternewman added a commit to peternewman/ola that referenced this issue Aug 27, 2015
nomis52 added a commit that referenced this issue Aug 27, 2015
Correct the function name of _AccountForMultiplier, closes #884
@peternewman peternewman added this to the 0.9.8 milestone Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants