Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vast majority of outstanding Python 3 issues #1761

Merged
merged 79 commits into from
Feb 26, 2023
Merged

Fix vast majority of outstanding Python 3 issues #1761

merged 79 commits into from
Feb 26, 2023

Conversation

peternewman
Copy link
Member

@peternewman peternewman commented Dec 31, 2021 •
edited
Loading

Found when trying to actually run the tools.

Untested on Python < 3.

  • Fix --list-tests and the RDM responder test class selection stuff in GetTestClasses due to them not being loaded
  • Fix DownloadModelData returning blank info
  • Fix SetNonAsciiDeviceLabel causing a UTF-8 decode error on the validate
  • Decide if this UTF-8 supporting behaviour is the correct way to go, or if we should wait for the new E1.20 to be released with it in

@peternewman peternewman added this to the 0.10.9 milestone Dec 31, 2021
@peternewman peternewman mentioned this pull request May 26, 2022
Closed
peternewman and others added 13 commits November 12, 2022 22:40
@peternewman peternewman mentioned this pull request Nov 19, 2022
Closed
peternewman added a commit that referenced this pull request Nov 20, 2022
@peternewman
Merge pull request #1797 from peternewman/0.10-clang-latest
526195a 
Cherry-pick some easy stuff from #1761
@peternewman peternewman linked an issue Nov 27, 2022 that may be closed by this pull request
Python 3 Compatibility #1506
Open
This was referenced Nov 27, 2022
Open
Closed
@peternewman peternewman changed the title Fix more Python 3 issues Fix vast majority of outstanding Python 3 issues Nov 29, 2022
@DaAwesomeP DaAwesomeP mentioned this pull request Feb 7, 2023
Merged
@peternewman
Comment out the SetNonAsciiDeviceLabel test for now as it breaks when…
45145ba 
… we try to decode its invalid ASCII and UTF-8 values, a TODO for another day...
@peternewman
Merge branch '0.10' of https://github.com/openlightingproject/ola int…
a8bfb32 
…o 0.10-c11-compat
@peternewman peternewman mentioned this pull request Feb 16, 2023
Merged
kripton
kripton approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I'm able to understand Python, it all makes sense to me :)

python/ola/StringUtils.py
except NameError:
unicode = str

__author__ = 'nomis52@gmail.com (Simon Newton)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not using your name as the author? you got it in line 16 as well

@peternewman peternewman merged commit bb3fb8b into OpenLightingProject:0.10 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripton kripton kripton approved these changes

Assignees
No one assigned
Labels
Maintainability
Projects
None yet
Milestone
0.10.9
Development

Successfully merging this pull request may close these issues.

Python 3 Compatibility
2 participants
@peternewman @kripton