E1.33 cherry pick part 4 #1950
Merged
E1.33 cherry pick part 4 #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bdb40db)
(cherry picked from commit 847734f)
…heartbeat behaviour and timing (cherry picked from commit 4d7049c)
(cherry picked from commit d1eb7b8)
(cherry picked from commit 669e2e5)
(cherry picked from commit ec58616)
(cherry picked from commit 40ff84c)
(cherry picked from commit b3942cf)
(cherry picked from commit 218c4c7)
(cherry picked from commit e00322d)
(cherry picked from commit 16455b1)
|
Spelling will be fixed once #1952 is merged in. |
Done :) |
(cherry picked from commit 91e014f)
kripton
approved these changes
Apr 8, 2024
Yeah I like a bit of test driven development; make it segfault, then stop it doing so! |
|
Okay I think that's the outstanding comments fixed in one way or another @kripton . |
peternewman
merged commit b93b8e0
into
OpenLightingProject:master
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.