Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of the new libusb plugin code. #538

Merged
merged 3 commits into from
Nov 25, 2014

Conversation

nomis52
Copy link
Member

@nomis52 nomis52 commented Nov 24, 2014

Breaking this up so it's easier for you to review.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) when pulling 8ac6bdf on nomis52:libusb-int into 8818716 on OpenLightingProject:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) when pulling 8ac6bdf on nomis52:libusb-int into 8818716 on OpenLightingProject:master.

return true;
}

bool LibUsbAdaptor::CheckManufacturer(const string &expected,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason these aren't taking a DeviceInformation and a string? The code to use them isn't in this PR, so that may affect it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real reason, fixed.

this plugin used the synchronous interface, and spawned a thread for every USB
device present.

The new version of the plugin uses the asynchronous mode of operation and a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth saying why we're switching?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@peternewman
Copy link
Member

A few comments, mostly fairly minor. That's all this block of code reviewed now.

nomis52 added a commit that referenced this pull request Nov 25, 2014
Initial commit of the new libusb plugin code.
@nomis52 nomis52 merged commit b3a85a3 into OpenLightingProject:master Nov 25, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) when pulling 42bb492 on nomis52:libusb-int into 8818716 on OpenLightingProject:master.

@peternewman
Copy link
Member

We should probably try and port across the other fixes into libusb's comments itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants