Initial commit of the new libusb plugin code. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } | ||
|
|
||
| bool LibUsbAdaptor::CheckManufacturer(const string &expected, |
There was a problem hiding this comment.
Is there any reason these aren't taking a DeviceInformation and a string? The code to use them isn't in this PR, so that may affect it.
| this plugin used the synchronous interface, and spawned a thread for every USB | ||
| device present. | ||
|
|
||
| The new version of the plugin uses the asynchronous mode of operation and a |
There was a problem hiding this comment.
Is it worth saying why we're switching?
|
A few comments, mostly fairly minor. That's all this block of code reviewed now. |
nomis52
added a commit
that referenced
this pull request
Nov 25, 2014
Initial commit of the new libusb plugin code.
|
We should probably try and port across the other fixes into libusb's comments itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking this up so it's easier for you to review.