-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of the new libusb plugin code. #538
Conversation
return true; | ||
} | ||
|
||
bool LibUsbAdaptor::CheckManufacturer(const string &expected, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason these aren't taking a DeviceInformation and a string? The code to use them isn't in this PR, so that may affect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real reason, fixed.
this plugin used the synchronous interface, and spawned a thread for every USB | ||
device present. | ||
|
||
The new version of the plugin uses the asynchronous mode of operation and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth saying why we're switching?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
A few comments, mostly fairly minor. That's all this block of code reviewed now. |
Initial commit of the new libusb plugin code.
We should probably try and port across the other fixes into libusb's comments itself. |
Breaking this up so it's easier for you to review.