Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the generic device / ports and the sunlite code. #544

Merged
merged 5 commits into from
Nov 28, 2014

Conversation

nomis52
Copy link
Member

@nomis52 nomis52 commented Nov 27, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.11%) when pulling 58c7ec5 on nomis52:libusb-int into 8bc7854 on OpenLightingProject:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.32%) when pulling f49cb3a on nomis52:libusb-int into 8bc7854 on OpenLightingProject:master.

namespace usbdmx {

/**
* @brief An Generic device.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPaG A

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

nomis52 added a commit that referenced this pull request Nov 28, 2014
Add the generic device / ports and the sunlite code.
@nomis52 nomis52 merged commit dae3970 into OpenLightingProject:master Nov 28, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.32%) when pulling d890a2e on nomis52:libusb-int into 8bc7854 on OpenLightingProject:master.


packet[i] = 0x80;
packet[i + 1] = channel / 2;
packet[i + 2] = 0x84;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth the 0x84 being a constant? Or is this actually 0x80 | 0x04.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually have no idea. I found this code somewhere :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants