-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the generic device / ports and the sunlite code. #544
Conversation
namespace usbdmx { | ||
|
||
/** | ||
* @brief An Generic device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPaG A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Add the generic device / ports and the sunlite code.
|
||
packet[i] = 0x80; | ||
packet[i + 1] = channel / 2; | ||
packet[i + 2] = 0x84; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth the 0x84 being a constant? Or is this actually 0x80 | 0x04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have no idea. I found this code somewhere :).
No description provided.