Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up signal handling a bit. #574

Merged
merged 3 commits into from
Dec 12, 2014
Merged

Conversation

nomis52
Copy link
Member

@nomis52 nomis52 commented Dec 12, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling ca83282 on nomis52:master into 2779984 on OpenLightingProject:master.

@@ -163,8 +162,7 @@ bool SetThreadScheduling() {
return false;
}

if (!ola::InstallSignal(SIGXCPU, _SIGXCPU_Handler)) {
OLA_WARN << "Failed to install signal SIGXCPU";
if (!ola::InstallSignal(SIGXCPU, _DumpStackAndExit)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need wrapping in #if HAVE_DECL_RLIMIT_RTTIME?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that was there because the function was only used if the signal was installed. Now that it's a common function we don't need it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@peternewman
Copy link
Member

LGTM, just minor comments.

@peternewman
Copy link
Member

LGTM

nomis52 added a commit that referenced this pull request Dec 12, 2014
Clean up signal handling a bit.
@nomis52 nomis52 merged commit 1d2c766 into OpenLightingProject:master Dec 12, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 441b847 on nomis52:master into 2779984 on OpenLightingProject:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants