-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up signal handling a bit. #574
Conversation
@@ -163,8 +162,7 @@ bool SetThreadScheduling() { | |||
return false; | |||
} | |||
|
|||
if (!ola::InstallSignal(SIGXCPU, _SIGXCPU_Handler)) { | |||
OLA_WARN << "Failed to install signal SIGXCPU"; | |||
if (!ola::InstallSignal(SIGXCPU, _DumpStackAndExit)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need wrapping in #if HAVE_DECL_RLIMIT_RTTIME?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that was there because the function was only used if the signal was installed. Now that it's a common function we don't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
LGTM, just minor comments. |
LGTM |
Clean up signal handling a bit.
No description provided.