Windows HTTP timeout workaround #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -488,8 +488,14 @@ void *HTTPServer::Run() { | |||
|
|
|||
| OLA_INFO << "HTTP Server started on port " << m_port; | |||
|
|
|||
| #ifdef _WIN32 | |||
| // set a short poll interval since we'd block too long otherwise. | |||
| // TODO(LE) investigate why the poller does not wake up on HTTP requests. | |||
There was a problem hiding this comment.
We've generally gone for TODO(firstname) rather than initials.
|
LGTM |
nomis52
added a commit
that referenced
this pull request
Dec 16, 2014
Windows HTTP timeout workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces the poll timeout to one second to make the HTTP server more responsive.
Even though the sockets are set to non-blocking mode, the poller does not wake up before the timeout. The calls to ioctlsocket to succeed. This issue will require further investigation.