Remove the override that prevents Sync Bulk Transfers from working in As... #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Async mode. This is required for the fadecandy init code to work, until such time as we make it async.
|
This closes #559 . |
|
Given this is a not so good thing; using a sync within an async mode, should we not wrap the call to base in a function so we can log things accidentally using it to fix in future. |
|
How about that? |
|
LGTM. We should probably have a todo in either this code or probably better in the Fadecandy one to make things fully async in the future. |
nomis52
added a commit
that referenced
this pull request
Dec 21, 2014
Remove the override that prevents Sync Bulk Transfers from working in As...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ync mode.
This is required for the fadecandy init code to work, until such time as we
make it async.