Add support for auto mode of Ja Rule #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if_nametoindex inet_ntoa inet_aton select socket strerror \ | ||
| getifaddrs getloadavg getpwnam_r getpwuid_r getgrnam_r \ | ||
| getgrgid_r secure_getenv]) | ||
| if_nametoindex inet_ntoa inet_ntop inet_aton inet_pton select \ |
There was a problem hiding this comment.
These are ready for #788 .
|
I think it would be much easier if we just avoid passing --enable-jarule to the pi build slaves. I want to remove this flag as soon as I can, so there isn't much to gain by trying to make it complicated. |
|
We could do, but that involves a chunk of buildbot copy/paste, and when we remove the flag, we'll still need some logic to build Ja Rule automatically if possible (although I guess that could be in ifdefs in the code). |
|
I'd prefer to copy and paste in buildbot rather than here. My goal is for the ja-rule code to be build if the libusb plugin is enabled and the appropriate version is met. That way we can get rid of the flag all together. |
|
Okay, understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure which branch I'm supposed to merge into, I still need to fix input validation too.