Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture test does not check all channel number strings in mode name #700

Closed
FloEdelmann opened this issue Dec 3, 2018 · 0 comments
Closed

Fixture test does not check all channel number strings in mode name #700

FloEdelmann opened this issue Dec 3, 2018 · 0 comments
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. component-test Affects the automated tests. good first issue Easy to pick up for new contributors. Only little domain knowledge required. via-editor Opened via the editor on the open-fixture-library.org website.

Comments

@FloEdelmann
Copy link
Member

Manufacturer: Clay Paky
Fixture: Alpha Spot QWO 800
Message: The "Vector 32-channel mode" actually has 36 channels. The shortName "36ch" is correct. Our fixture test should find that case!

Thank you @FloEdelmann!
@FloEdelmann FloEdelmann added component-fixture Affects one or more existing fixture definitions. via-editor Opened via the editor on the open-fixture-library.org website. good first issue Easy to pick up for new contributors. Only little domain knowledge required. bug Something doesn't work as intended. component-test Affects the automated tests. labels Dec 3, 2018
@FloEdelmann FloEdelmann changed the title Feedback for fixture 'clay-paky/alpha-spot-qwo-800' Fixture test does not check all channel number strings in mode name Dec 3, 2018
@FloEdelmann FloEdelmann mentioned this issue Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. component-test Affects the automated tests. good first issue Easy to pick up for new contributors. Only little domain knowledge required. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FloEdelmann