Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airflow] Extractors should repeat input/output metadata in both START and COMPLETE #1726

Closed
rossturk opened this issue Mar 20, 2023 · 2 comments · Fixed by #1771
Closed
Assignees

Comments

@rossturk
Copy link
Contributor

There is an OpenLineage consumer that does not aggregate metadata across the lifecycle of a run, opting instead to ignore all but COMPLETE event types. This is reasonable for the use case of this consumer; they care about schemas and lineage but not operational status. However, it means that if lineage is provided during a START event, this consumer will miss it.

It would be ideal to accumulate metadata across the run on the consumer side, but this is currently not possible. For the time being, we can repeat input/output metadata and facet metadata in both START and COMPLETE events to accommodate.

@collado-mike
Copy link
Contributor

This is the cause of some fairly frequent issues where an Airflow task fails before a START event is able to be sent (there seem to be a few paths to the on_task_instance_failed hook being called). The OL events can be quite large, so I understand the urge to reduce duplication, but unfortunately, it's causing some data to be missed entirely.

@denimalpaca
Copy link
Contributor

This is already default BaseExtractor behavior, so we just have to go through the extractors and make sure that their extract_on_complete() do not just pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants