Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow: Remove explicit pass from several extract_on_complete methods. #1771

Merged
merged 1 commit into from Apr 15, 2023

Conversation

JDarDagran
Copy link
Contributor

Problem

Possibly closes: #1726

Solution

Remove explicit pass from 3 extractors' extract_on_complete methods.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>

Adjust expected events in integration tests.

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran JDarDagran merged commit 0eef1fd into main Apr 15, 2023
21 checks passed
@JDarDagran JDarDagran deleted the airflow/remove-explicit-pass-on-complete branch April 15, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration/airflow openlineage-airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[airflow] Extractors should repeat input/output metadata in both START and COMPLETE
2 participants