sql parser: do not fail whole extraction on partial failures, report ExtractionErrorRunFacet #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
ci
client/python
common
extractor
integration/airflow
integration/sql
labels
JDarDagran
approved these changes
Jan 9, 2023
integration/airflow/tests/integration/requests/failed_sql_extraction.json
Show resolved
Hide resolved
integration/sql/iface-java/src/test/java/io/openlineage/sql/OpenLineageSqlTest.java
Show resolved
Hide resolved
integration/sql/iface-java/src/main/java/io/openlineage/sql/ExtractionError.java
Show resolved
Hide resolved
integration/sql/iface-java/src/main/java/io/openlineage/sql/ExtractionError.java
Show resolved
Hide resolved
integration/sql/iface-java/src/main/java/io/openlineage/sql/SqlMeta.java
Outdated
Show resolved
Hide resolved
…them instead Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
sql/do-not-fail-on-partial-extraction
branch
from
5950b30
to
6530693
Compare
pawel-big-lebowski
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ability for a SQL parser to report errors to integration that's calling it, and integrations to report those error using
ExtractionErrorRunFacet.Additionally, the behavior (and API) of parser changes - if it fails to parse some part of SQL statements send to it, it won't raise exception and fail whole extraction, but report partial failure from which some input and output datasets still can be extracted. PR also changes integrations to take care of that API change.
Signed-off-by: Maciej Obuchowski obuchowski.maciej@gmail.com
Closes: #1052, partially closes #1333