Make OPENLINEAGE_DISABLED case insensitive #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the python client and Airflow plugin, check OPENLINEAGE_DISABLED in a case insensitive way. Signed-off-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
denimalpaca
reviewed
Mar 8, 2023
Comment on lines
+101
to
+106
| ("true", True), | ||
| ("True", True), | ||
| ("TRUE", True), | ||
| ("false", False), | ||
| ("False", False), | ||
| ("FALSE", False), |
There was a problem hiding this comment.
If this is going to come from an environment variable, does that imply it's always a string? Or can these vars also come in as a True or False boolean?
There was a problem hiding this comment.
Sorry, meant to comment on that. Yes, getenv always returns a string.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1705 +/- ##
============================================
+ Coverage 83.34% 85.35% +2.00%
============================================
Files 89 69 -20
Lines 4006 3668 -338
Branches 29 0 -29
============================================
- Hits 3339 3131 -208
+ Misses 635 537 -98
+ Partials 32 0 -32 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mobuchowski
approved these changes
Mar 8, 2023
|
Great job! Congrats on your first merged pull request in OpenLineage! |
harels
pushed a commit
to harels/OpenLineage
that referenced
this pull request
May 11, 2023
In the python client and Airflow plugin, check OPENLINEAGE_DISABLED in a case insensitive way. Signed-off-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It can be surprising that OPENLINEAGE_DISABLED is case sensitive.
Closes: #1704
Solution
In the python client and Airflow plugin, check OPENLINEAGE_DISABLED in a case insensitive way.
Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project