python: deprecate client.from_environment, do not skip loading config on it #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on it Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 6, 2023
There was a breaking change in the openlineage-integration-common that broke the way configuration was read. There is a PR in OpenLineage/OpenLineage#1908 to address it that will be merged and released soon. We should exclude the version that contains the breaking change.
JDarDagran
approved these changes
Jun 6, 2023
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Jun 6, 2023
…31739) There was a breaking change in the openlineage-integration-common that broke the way configuration was read. There is a PR in OpenLineage/OpenLineage#1908 to address it that will be merged and released soon. We should exclude the version that contains the breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.27.1, we added filters to Python OL client. This required us to move place where OL config is read - which now is on client construction, not transport.
However, OpenLineageClient.from_environment() method wasn't changed to accomodate that - and using it skipped config loading.
This change deprecates that method and recommends using constructor instead - after the fix, using it shouldn't differ now from using constructor.