Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK] Migrated 'spark3' module to produce Scala 2.12 and Scala 2.13 variants #2385

Conversation

d-m-h
Copy link
Contributor

@d-m-h d-m-h commented Jan 21, 2024

Summary: Migrated 'spark3' module to produce Scala 2.12 and Scala 2.13 variants

Problem

Spark 3.2.x, 3.3.x, 3.4.x, and 3.5.x are compiled using Scala 2.12 and Scala 2.13. Due to a change in the Scala Collections API in Scala 2.13, NoSuchMethodErrors are thrown when running the openlineage-spack connector in an Apache Spark runtime when the runtime was compiled using Scala 2.13.

Relates to: #2303

Solution

This PR is the fifth of several PRs to support producing Scala 2.12 and Scala 2.13 variants of the OpenLineage Spark integration.

In this PR, we migrate the 'spark3' module to use the refactored Gradle plugins.

The module now produces 3 JARS; one default one, one compiled using the Scala 2.12 variant of Apache Spark, and one compiled using the Scala 2.13 variant of Apache Spark.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your change contains a small diff and is self-contained
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation integration/spark labels Jan 21, 2024
@d-m-h d-m-h force-pushed the feature/prep-for-scala_2.13-support-number-5 branch from 8d75588 to 9937acf Compare January 21, 2024 17:50
@d-m-h d-m-h changed the title [SPARK] Migrated 'shared' module to produce Scala 2.12 and Scala 2.13 variants [SPARK] Migrated 'spark3' module to produce Scala 2.12 and Scala 2.13 variants Jan 21, 2024
@d-m-h d-m-h force-pushed the feature/prep-for-scala_2.13-support-number-5 branch 7 times, most recently from cec6f1d to 6f3bc37 Compare January 22, 2024 15:53
@JDarDagran JDarDagran force-pushed the feature/prep-for-scala_2.13-support-number-5 branch from 6f3bc37 to a1b285e Compare January 22, 2024 18:17
@d-m-h d-m-h force-pushed the feature/prep-for-scala_2.13-support-number-5 branch from a1b285e to 685878d Compare January 23, 2024 10:48
Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
@d-m-h d-m-h force-pushed the feature/prep-for-scala_2.13-support-number-5 branch from 685878d to 13fb05e Compare January 23, 2024 11:34
@pawel-big-lebowski pawel-big-lebowski merged commit 41f5f89 into OpenLineage:main Jan 23, 2024
23 checks passed
@d-m-h d-m-h deleted the feature/prep-for-scala_2.13-support-number-5 branch January 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation integration/spark
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants