[FLINK] improve Cassandra lineage metadata #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuangZhenQiu
force-pushed
the
improve-cassandra-lineage
branch
2 times, most recently
from
4a0c705
to
cd699b5
Compare
boring-cyborg
bot
added
the
area:documentation
integration/flink/app/src/test/resources/events/expected_cassandra.json
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased](https://github.com/OpenLineage/OpenLineage/compare/1.9.1...HEAD) | |||
| * **Flink: improve Cassandra lineage metadata** (https://github.com/OpenLineage/OpenLineage/pull/2479) [@HuangZhenQiu](https://github.com/HuangZhenQiu) | |||
There was a problem hiding this comment.
Would it be worth adding Cassandra naming convention to:
- https://openlineage.io/docs/spec/naming
- https://github.com/OpenLineage/OpenLineage/blob/main/spec/Naming.md
Sorry for having same definition in both places.
There was a problem hiding this comment.
Updated in https://github.com/OpenLineage/OpenLineage/blob/main/spec/Naming.md. But I am not able to find the source doc file for https://openlineage.io/docs/spec/naming.
There was a problem hiding this comment.
|
|
||
| private static Optional<String> convertToNamespace(Optional<List<Object>> endpointsOpt) { | ||
| if (endpointsOpt.isPresent() && !endpointsOpt.isEmpty()) { | ||
| return Optional.of("cassandra://" + endpointsOpt.get().get(0).toString().split("/")[1]); |
There was a problem hiding this comment.
this can still fail on endpointsOpt.get().get(0) being null or endpointsOpt.get().get(0).toString().split("/") having single element.
There was a problem hiding this comment.
Good catch. Added more strict pattern verification.
HuangZhenQiu
force-pushed
the
improve-cassandra-lineage
branch
from
cd699b5
to
5f18794
Compare
boring-cyborg
bot
added
the
area:spec
HuangZhenQiu
force-pushed
the
improve-cassandra-lineage
branch
2 times, most recently
from
858deb0
to
34d01c6
Compare
Signed-off-by: Zhenqiu Huang <huangzhenqiu0825@gmail.com>
HuangZhenQiu
force-pushed
the
improve-cassandra-lineage
branch
from
34d01c6
to
036c608
Compare
pawel-big-lebowski
approved these changes
Mar 1, 2024
Ruihua98
pushed a commit
to Ruihua98/OpenLineage
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Zhenqiu Huang <huangzhenqiu0825@gmail.com> Signed-off-by: Ruihua Wang <ruihuawang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary:
Following the namespace definition, we should use cassandra://host:port as format, so that users can find which Cassandra cluster is used. At the same time, Cassandra keyspace and table name can be combined as name.
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project