Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagster: add new latest version provider in conftest #2518

Merged
merged 1 commit into from Mar 15, 2024

Conversation

JDarDagran
Copy link
Contributor

@JDarDagran JDarDagran commented Mar 14, 2024

Problem

30 minutes from now new version of Dagster was released. It breaks tests with latest version.

Solution

Add new provider for latest version as advised in docstrings.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@boring-cyborg boring-cyborg bot added the area:integration/dagster openlineage-dagster label Mar 14, 2024
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran JDarDagran changed the title dagster: try to import new module for ExternalRepositoryOrigin. dagster: add new latest version provider in conftest Mar 14, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c3765bf) to head (a4df366).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             main     #2518       +/-   ##
============================================
+ Coverage   84.47%   100.00%   +15.52%     
============================================
  Files          59         5       -54     
  Lines        3355       173     -3182     
============================================
- Hits         2834       173     -2661     
+ Misses        521         0      -521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mobuchowski mobuchowski merged commit b004357 into main Mar 15, 2024
12 checks passed
@mobuchowski mobuchowski deleted the dagster/fix-1.6.10-changes branch March 15, 2024 08:45
mobuchowski pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
blacklight pushed a commit to blacklight/OpenLineage that referenced this pull request Apr 4, 2024
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration/dagster openlineage-dagster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants