metrics, spark: add support for telemetry mechanism in Spark integration #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:client/java
client/java/src/main/java/io/openlineage/client/metrics/MetricsResolver.java
Outdated
Show resolved
Hide resolved
integration/spark/app/src/main/java/io/openlineage/spark/agent/OpenLineageSparkListener.java
Show resolved
Hide resolved
client/java/src/main/java/io/openlineage/client/metrics/MetricsResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Left few single comments' feedback above. Overall I am really happy with the progress you do on the PR and the shape it becomes. Amazing job @mobuchowski 🥇
mobuchowski
force-pushed
the
openlineage-metrics-spark
branch
5 times, most recently
from
19ced62
to
4ccf656
Compare
There was a problem hiding this comment.
This code looks really well and I appreciate the solution to extract timers for facet builders.
Did you experience any problems with testing? I couldn't find any new tests added. Would it make sense to see a debug facet filled with timers for each visitor and builder?
integration/spark/app/src/main/java/io/openlineage/spark/agent/OpenLineageSparkListener.java
Outdated
Show resolved
Hide resolved
mobuchowski
force-pushed
the
openlineage-metrics-spark
branch
3 times, most recently
from
d7d2637
to
43d6deb
Compare
integration/spark/app/src/test/java/io/openlineage/spark/agent/SparkGenericIntegrationTest.java
Outdated
Show resolved
Hide resolved
integration/spark/shared/src/main/java/io/openlineage/spark/agent/JobMetricsHolder.java
Outdated
Show resolved
Hide resolved
...rk/shared/src/main/java/io/openlineage/spark/agent/lifecycle/OpenLineageRunEventBuilder.java
Show resolved
Hide resolved
...ration/spark/app/src/test/java/io/openlineage/spark/agent/SparkContainerIntegrationTest.java
Outdated
Show resolved
Hide resolved
mobuchowski
force-pushed
the
openlineage-metrics-spark
branch
2 times, most recently
from
a411c2c
to
6d93dfe
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
openlineage-metrics-spark
branch
from
6d93dfe
to
7067a88
Compare
pawel-big-lebowski
approved these changes
Apr 4, 2024
blacklight
pushed a commit
to blacklight/OpenLineage
that referenced
this pull request
Apr 4, 2024
OpenLineage#2528) Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com> Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows previous metrics PR #2496 and adds instrumentation to the Spark integration. This comprises of