New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spark] Fix databricks environment #2537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-big-lebowski
force-pushed
the
spark/fix-databricks-test
branch
from
March 27, 2024 10:55
bdabc88
to
2bb33b8
Compare
pawel-big-lebowski
changed the title
[Spark] fix databricks environment
[Spark] Fix databricks environment
Mar 27, 2024
pawel-big-lebowski
force-pushed
the
spark/fix-databricks-test
branch
4 times, most recently
from
March 28, 2024 11:11
5837791
to
350dde6
Compare
Successful CI run with databricks tests |
8 tasks
pawel-big-lebowski
force-pushed
the
spark/fix-databricks-test
branch
from
March 28, 2024 12:08
350dde6
to
d1c6133
Compare
mobuchowski
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, besides looks good to me.
integration/spark/app/src/test/java/io/openlineage/spark/agent/DatabricksIntegrationTest.java
Show resolved
Hide resolved
integration/spark/app/src/test/java/io/openlineage/spark/agent/DatabricksUtils.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/openlineage/spark/agent/facets/builder/DatabricksEnvironmentFacetBuilder.java
Show resolved
Hide resolved
pawel-big-lebowski
force-pushed
the
spark/fix-databricks-test
branch
from
April 2, 2024 13:01
d1c6133
to
de7877a
Compare
boring-cyborg
bot
added
the
area:documentation
Improvements or additions to documentation
label
Apr 2, 2024
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
pawel-big-lebowski
force-pushed
the
spark/fix-databricks-test
branch
from
April 2, 2024 15:25
de7877a
to
89dca31
Compare
blacklight
pushed a commit
to blacklight/OpenLineage
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Databricks integration test is triggered manually and has not been triggered for some time. Meanwhile:
DatabricksEnvironmentFacetBuilder
uses compileOnly class dependency which are no longer present on databricks environment which causesClassNotFoundError
Solution
com.databricks.backend.daemon.dbutils.MountInfo
)Follow up issues:
Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a schema change, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change, then select one of the following:
If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports
S3
andGCS
filesystem operations, tested with AWS EMR).One-line summary:
Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project