Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT] Small improvements of .emit() method logging & annotations #2539

Merged
merged 1 commit into from Mar 28, 2024

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Mar 27, 2024

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

  • Do not print debug message "client will emit event" if event is filtered out
  • Do not fail if transport is not set up when event is ignored
  • Do not mix Union[A, B] and A | B annotations syntax, prefer the latter

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a schema change, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change, then select one of the following:

Note: All schema changes require discussion. Please link the issue for context.

  • Your change modifies the core OpenLineage model
  • Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).

One-line summary:

Small updates to OpenLineage.emit debug messages and annotations

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@boring-cyborg boring-cyborg bot added the area:client/python openlineage-python label Mar 27, 2024
Copy link

boring-cyborg bot commented Mar 27, 2024

Thanks for opening your first OpenLineage pull request! We appreciate your contribution. If you haven't already, please make sure you've reviewed our guide for new contributors (https://github.com/OpenLineage/OpenLineage/blob/main/CONTRIBUTING.md).

@dolfinus dolfinus force-pushed the patch-1 branch 3 times, most recently from 0ee6d7b to 86a1bb7 Compare March 27, 2024 14:28
* Do not print debug message "client will emit event" if event is filtered out
* Do not fail if transport is not set up if event is ignored
* Update annotations a bit

Signed-off-by: Maxim Martynov <martinov_m_s_@mail.ru>
@dolfinus dolfinus changed the title Small improvements of OpenLineageClient.emit [CLIENT] Small improvements of .emit() method logging & annotations Mar 27, 2024
Copy link
Contributor

@JDarDagran JDarDagran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dolfinus for the contribution!

@JDarDagran JDarDagran merged commit 1c60584 into OpenLineage:main Mar 28, 2024
31 checks passed
Copy link

boring-cyborg bot commented Mar 28, 2024

Great job! Congrats on your first merged pull request in OpenLineage!

@dolfinus dolfinus deleted the patch-1 branch March 28, 2024 12:40
blacklight pushed a commit to blacklight/OpenLineage that referenced this pull request Apr 4, 2024
…penLineage#2539)

* Do not print debug message "client will emit event" if event is filtered out
* Do not fail if transport is not set up if event is ignored
* Update annotations a bit

Signed-off-by: Maxim Martynov <martinov_m_s_@mail.ru>
Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client/python openlineage-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants