Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Show error message then OpenLineageSql cannot find native library #2547

Merged

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Mar 29, 2024

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

If OpenLineageSql class cannot load native library, if returns None for all operations. But the error message is suppressed, and user cannot determine the reason.

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a schema change, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change, then select one of the following:

Note: All schema changes require discussion. Please link the issue for context.

  • Your change modifies the core OpenLineage model
  • Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).

One-line summary:

Show error messages when OpenLineageSql cannot load native library.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru>
@boring-cyborg boring-cyborg bot added area:documentation Improvements or additions to documentation area:integration/sql labels Mar 29, 2024
@mobuchowski mobuchowski self-requested a review March 29, 2024 14:07
Copy link
Member

@mobuchowski mobuchowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dolfinus .

@mobuchowski mobuchowski merged commit 82c92f6 into OpenLineage:main Mar 29, 2024
70 checks passed
@dolfinus dolfinus deleted the bug/sql-java-missing-lib-error branch March 29, 2024 15:12
blacklight pushed a commit to blacklight/OpenLineage that referenced this pull request Apr 4, 2024
…enLineage#2547)

Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru>
Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation area:integration/sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants