dbt: dbt-ol should transparently exit with the same exit code as the child dbt process
#2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t code as the underlying dbt process Also in this commit: - Use lazy template evaluation instead of f-strings for logging (see https://realpython.com/python-f-strings/#lazy-evaluation-in-logging) - `subprocess.Popen` should always be run through a context manager. Signed-off-by: Fabio Manganiello <fabio.manganiello@booking.com>
JDarDagran
approved these changes
Apr 3, 2024
mobuchowski
approved these changes
Apr 3, 2024
|
Great job! Congrats on your first merged pull request in OpenLineage! |
blacklight
added a commit
to blacklight/OpenLineage
that referenced
this pull request
Apr 4, 2024
…t code as the underlying dbt process (OpenLineage#2560) Also in this commit: - Use lazy template evaluation instead of f-strings for logging (see https://realpython.com/python-f-strings/#lazy-evaluation-in-logging) - `subprocess.Popen` should always be run through a context manager. Signed-off-by: Fabio Manganiello <fabio.manganiello@booking.com> Co-authored-by: Fabio Manganiello <fabio.manganiello@booking.com> Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
blacklight
added a commit
to blacklight/OpenLineage
that referenced
this pull request
Apr 9, 2024
…eage events are emitted. This is a follow-up [/missed corner case] of OpenLineage#2560 Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
10 tasks
mobuchowski
pushed a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #2558
If
dbt-oldoesn't exit with the same code as the childdbtprocess, then any upstream process(es), including Airflow DAGs, won't be able to detect workflow failures.Closes: #2558
Solution
dbt-ol.mainshould return thereturn_codeof the childdbtprocess, and we should explicitlysys.exitit.This PR also adds a couple of extra changes to make the code of
dbt-olmore PEP/Flake compliant. In particular:Logging functions should favor lazy evaluation over f-strings.
subprocess.Popenshould always be run through a context manager (for proper process/resources clean up).One-line summary:
dbt-olshould transparently exit with the same exit code as the childdbtprocess.Checklist
[ ] Your changes are accompanied by tests (if relevant)- [ ] You've updated any relevant documentation (if relevant)- [ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)- [ ] You've added a header to source files (if relevant)SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project