spark,snowflake: support query option via SQL parser #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
spark/snowflake-complex
branch
from
5ff80b7
to
55f4a6c
Compare
pawel-big-lebowski
approved these changes
Apr 3, 2024
| @@ -35,20 +42,15 @@ public static <D extends OpenLineage.Dataset> D getDataset( | |||
| // An improvement could be put the query string in the `DatasetFacets` | |||
| if (dbtable.isPresent()) { | |||
| tableName = dbtable.get(); | |||
| String name = String.format("%s.%s.%s", sfDatabase, sfSchema, tableName); | |||
There was a problem hiding this comment.
would it make sense to add method in io.openlineage.client.utils.JdbcUtils instead?
There was a problem hiding this comment.
JDBCUtils deal with parsing JDBC URIs - this is not related to those I believe and is Snowflake specific.
...ke/src/main/java/io/openlineage/spark/agent/vendor/snowflake/lifecycle/SnowflakeDataset.java
Show resolved
Hide resolved
blacklight
pushed a commit
to blacklight/OpenLineage
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com> Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar (and based on) to #2556 but concerns Snowflake queries.
When Snowflake job is bypassing Spark's computation layer, use SQL parser to get the lineage.